Console view toolbar not shown after scrolling on v23.4.0

[asavchkov]

Issue Type

• Bug Report

Summary

In older versions of go-server up to 23.3.0 an toolbar was always available at the top of the console view regardless of the current scrolling position, i.e. no matter at which position of the console log I was (top, middle, bottom) this toolbar was present as a dynamic overlay panel. This is the toolbar I am talking about:

I have always found it very convenient and used it a lot to toggle the automatic log update, timestamps and the color theme (at times some text was hard to read with its current colors).

In v24.4.0 this toolbar no longer follows the current view but rather scrolls normally with the rest of the log content and immediately goes out of the view if I move a couple of lines down in the log.

Could you please put this nice toolbar back such that it is always available at the top of the view when scrolling console logs?

Basic environment details

• Go Version: 23.4.0 (17731-4deb96d823b921419680560be080588e900d406e).
• JAVA Version: 17.0.9
• OS: Linux 5.15.0-88-generic
• Browser vendor and version (if relevant): Mozilla Firefox 119.0

[chadlwilson]

There was no intention to change this, but it might have been a side effect of something else. There is a lot of old untested stuff on these views, unfortunately.

It might have been an accidental victim of a view framework upgrade like #11817, or some other CSS cleanup like 7274e1f (having no idea how it worked before).

[chadlwilson]

Ahh, just keeping a note for myself - it's likely that

gocd/server/src/main/webapp/WEB-INF/rails/app/assets/javascripts/lib/jquery-pinOnScroll.js

Lines 81 to 112 in 0f58107

	$.fn.pinOnScroll = function (opts) {
	this.each(function () {
	var elem = $(this);
	var throttledFixElement = _.throttle(fixElement, 100);
	var throttledUnFixElement = _.throttle(unFixElement, 100);
	$(window).on('scroll.pinOnScroll', function () {
	maybeCallUsingRequestAnimationFrame(function () {
	throttledFixElement(elem, opts);
	});
	});
	$(window).on('resize.pinOnScroll', function () {
	maybeCallUsingRequestAnimationFrame(function () {
	throttledUnFixElement(elem, opts);
	throttledFixElement(elem, opts);
	});
	});
	$(window).on('resetPinOnScroll', function (e, eParams) {
	if (eParams.calcRequiredScroll) {
	opts.requiredScroll = eParams.calcRequiredScroll();
	}
	throttledUnFixElement(elem, opts);
	throttledFixElement(elem, opts);
	});
	});
	return this;
	};
	}(jQuery));

is not working as expected with the newer jquery versions.