Change baseline to require Java 17 minimum #12415

chadlwilson · 2023-12-30T15:57:41Z

Increases the baseline Java version to 17, which has been out for 2.5 years now, and has been packaged with GoCD for quite a long time now
Fixes the go-plugin-api version at Java 11 to avoid plugins having to increase their own version just to stay compatible with newer versions of the plugin API
Fixes issues with JVM version of the jar-class-loader which is intended to target old versions to be able to display useful errors to users. This was intended to support Java 8 onwards, but has been broken for a while and was actually effectively Java 11 on 23.5.0 and back a number of versions. This fixes that.
Removes compatibility declarations from MANIFEST.MF as some where inaccurate, and it is not a mandatory declaration. It's also misleading in some cases of uber/fatjars. Seems unnecessary.

chadlwilson added technical java Pull requests that update Java code labels Dec 30, 2023

chadlwilson added this to the Release 24.1.0 milestone Dec 30, 2023

chadlwilson force-pushed the java-17-minimum branch 4 times, most recently from c29f57c to 1c31e84 Compare January 5, 2024 04:21

chadlwilson force-pushed the java-17-minimum branch 11 times, most recently from 0329ad7 to ed37d16 Compare January 14, 2024 08:59

chadlwilson added 5 commits January 14, 2024 17:40

Require Java 17 minimum

f849a44

Prefer pattern variables

0f58263

Prefer enhanced switch statements

9417639

Prefer text blocks

763baaf

Tidy for older Java language features

1f3fee0

chadlwilson force-pushed the java-17-minimum branch from ed37d16 to 1f3fee0 Compare January 14, 2024 09:41

chadlwilson marked this pull request as ready for review January 14, 2024 09:45

chadlwilson merged commit 0440ffe into gocd:master Jan 14, 2024
1 of 2 checks passed

chadlwilson deleted the java-17-minimum branch January 14, 2024 09:45

Provide feedback