Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific test for a real gocd-agent-docker-dind usage #12773

Closed
chadlwilson opened this issue May 15, 2024 · 0 comments · Fixed by #12774
Closed

Add specific test for a real gocd-agent-docker-dind usage #12773

chadlwilson opened this issue May 15, 2024 · 0 comments · Fixed by #12774

Comments

@chadlwilson
Copy link
Member

chadlwilson commented May 15, 2024

There have been a couple of incidents in the last year where something has changed within the base docker:dind image that has caused our agent image to break when actually used with a docker-in-docker or docker-out-of-docker workflow.

In both cases this could have been caught if the functional test that validates the dind image ran a simple task such as docker run hello-world (or arguably a simple docker build) which actually interacts with the domain and/or docker sock mounted.

Although this would be docker-in-docker-in-docker, I believe this should work OK given we can share the host socker all the way through from ECS VM -> build.gocd.org centos agent container -> gocd-agent-docker-dind container -> docker run hello-world container

#11378
#12765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant