Updated web_hook_controller.rb to include gitlab@ urls #4211
+30
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Since this code is specific to gitlab, it should ideally belong to |
|
@ketan Thanks for the feedback. Ive copied the function to the gitlab webhook controller and added the changes needed and added it to the spec tests. |
|
I made a small tweak to your PR to extract the list of URLs into a method that can be overridden in each webhook subclass. |
Many Gitlab installations use gitlab@ as a git user. this was once a default user for gitlab installs. Due to this the urls for ssh connections from gitlab can include this user. Changing the user is a non trivial event.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many Gitlab installations use gitlab@ as a git user. this was once a default user for gitlab installs.
Due to this the urls for ssh connections from gitlab can include this user.
Changing the user is a non trivial event.
This adds gitlab to this list so that it can be used in gocd.