#000 - Fix plugin logging concurrency issue. #4542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to https://jira.qos.ch/browse/LOGBACK-1359, RollingFileAppender#start is not thread safe. Plugin logging service creates a rolling file appender and starts it. If multiple plugins try to log at the same time, a ConcurrentModificationException can happen.
It shows up as a test failure: https://build.gocd.org/go/tab/build/detail/build-linux/2345/build-non-server/1/plugin-infra