Agent remains in missing state

[bdpiprava]

Issue Type

• Bug Report

Summary

The job remains in a hung state when an agent goes missing.

Steps to Reproduce

1. Start the GoCD server and agent
2. Trigger a build
3. Terminate the agent when a job is assigned to the agent
4. Restart the GoCD server
5. The agent status will remain as missing on GoCD server event after the expiration of lastHeardTime

Basic environment details

• Go Version: Go Version: 18.6.0 (6865-2d19f6431294e4ccf60c8872a77d4b13cbd3837a)

Expected Results

After lastHeardTime timeout agent should be marked as Lost Contact and a job should be assigned to the new agent.

Possible Fix

A little tweak in following lines may fix the issue

https://github.com/gocd/gocd/blob/master/common/src/main/java/com/thoughtworks/go/domain/AgentInstance.java#L178-L180