Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No proper error msg is shown when a user's operate permission is removed from pipeline group when that user has also been given stage operate permission #49

Closed
mdaliejaz opened this issue Apr 16, 2014 · 3 comments

Comments

@mdaliejaz
Copy link
Contributor

Steps to reproduce

  1. Give user1 and user2 operate permissions to pipeline group PG1
  2. Give user1 stage operate permission forpipeline P1 in PG1
  3. Try to remove operate permissions of user1 from PG1

Expected result

This should not be allowed and a proper error message should be given for that

Current result

It just says Save failed, see errors below but does not show any error

@zabil zabil removed the backlog label Jun 3, 2015
@arvindsv arvindsv modified the milestone: Unknown - Needs interest from someone Jan 4, 2016
@stale
Copy link

stale bot commented Apr 2, 2020

This issue has been automatically marked as stale because it has not had activity in the last 90 days.
If you can still reproduce this error on the master branch using local development environment or on the latest GoCD Release, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.

@stale stale bot added the stale label Apr 2, 2020
@stale stale bot closed this as completed Apr 9, 2020
@kritika-singh3
Copy link
Contributor

Can still be reproduced:

  1. Give user1 and user2 operate permissions to pipeline group PG1
  2. Give user1 stage operate permission for a pipeline P1 in PG1
  3. Go to pipeline group edit on Pipelines page and remove the operate permission (or remove the user).

Expected Result

Error should be thrown as the user is still present on as a stage operate user in a pipeline P1

Actual Result

The updated authorization for the pipeline group gets saved. But any further update call to the pipeline P1 fails.
The cruise-config is rendered invalid (try to save the config without changes or restart the server - it won't come up).

@kritika-singh3 kritika-singh3 reopened this Apr 9, 2020
@stale stale bot removed the stale label Apr 9, 2020
@kritika-singh3 kritika-singh3 modified the milestones: Release: Unknown, NextUp Apr 9, 2020
@kritika-singh3 kritika-singh3 added this to To do in 20.3.0 Apr 9, 2020
@kritika-singh3 kritika-singh3 removed this from To do in 20.3.0 Apr 20, 2020
@kritika-singh3 kritika-singh3 added this to To do in 20.4.0 Apr 20, 2020
@maheshp maheshp removed this from To do in 20.4.0 May 19, 2020
@stale
Copy link

stale bot commented Jul 8, 2020

This issue has been automatically marked as stale because it has not had activity in the last 90 days.
If you can still reproduce this error on the master branch using local development environment or on the latest GoCD Release, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.

@stale stale bot added the stale label Jul 8, 2020
@stale stale bot closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants