Adding a package material via Package Repo page causes the pipeline to fail

[kritika-singh3]

Issue Type

• Bug Report

Summary

Adding a package material a pipeline via the new pipeline config spa fails the pipeline. If added via the old rails based page, the pipeline is green.

Basic environment details

• Go Version: GoCD Version: 20.4.0 (11669-dcb1fc4c5a26445c1091b81acc326d7219a53eed)

Steps to Reproduce

1. Add a package repo and package via the Package Repositories SPA.
2. Use the create pipeline wizard to create a pipeline with the package just created. Keep the task something simple - say ls.
3. Trigger the pipeline

Expected Results

The pipeline status should be green

Actual Results

The ls task fails.

Note: if you do a full config save and then trigger the same pipeline with no changes - the pipeline will turn green.

Any other info

You can use the following config to duplicate the error:

<repositories>
    <repository id="5ef6a39c-18fd-4240-8843-40e538b1229d" name="repo-1">
      <pluginConfiguration id="yum" version="" />
      <configuration>
        <property>
          <key>REPO_URL</key>
          <value>file:///tmp/packagerepo/file_repo</value>
        </property>
        <property>
          <key>USERNAME</key>
        </property>
        <property>
          <key>PASSWORD</key>
        </property>
      </configuration>
      <packages>
        <package id="58a804c6-f243-4d5f-9ec0-dd4ed3e9b21b" name="go-agent">
          <configuration>
            <property>
              <key>PACKAGE_SPEC</key>
              <value>go-agent</value>
            </property>
          </configuration>
        </package>
      </packages>
    </repository>
  </repositories>
  <pipelines group="defaultGroup">
    <pipeline name="pipeline_with_yum_repo_package_as_materialb327a3e3">
      <materials>
        <git url="/tmp/materials/gitmaterial-1588841060-fdd9f723/sample.git" dest="git" autoUpdate="false" materialName="git" />
        <package ref="58a804c6-f243-4d5f-9ec0-dd4ed3e9b21b" />
      </materials>
      <stage name="defaultStage">
        <jobs>
          <job name="defaultJob">
            <tasks>
              <exec command="echo">
                <arg>GO_REPO_TW_REPO_GO_AGENT_PASSWORD</arg>
              </exec>
              <exec command="/bin/sh">
                <arg>-c</arg>
                <arg>echo GO_REPO_TW_REPO_GO_AGENT_PASSWORD : $GO_REPO_TW_REPO_GO_AGENT_PASSWORD AND GO_PACKAGE_TW_REPO_GO_AGENT_LOCATION : $GO_PACKAGE_TW_REPO_GO_AGENT_LOCATION</arg>
                <runif status="passed" />
              </exec>
            </tasks>
          </job>
        </jobs>
      </stage>
    </pipeline>
  </pipelines>

[arvindsv]

Just to add: The difference when you save using the old Rails page is this:

  <repositories>
      <repository id="5ef6a39c-18fd-4240-8843-40e538b1229d" name="repo-1">
        <pluginConfiguration id="yum" version="" />
        <configuration>
          <property>
            <key>REPO_URL</key>
            <value>file:///tmp/packagerepo/file_repo</value>
          </property>
          <property>
            <key>USERNAME</key>
+           <value />
          </property>
          <property>
            <key>PASSWORD</key>
+           <encryptedValue />
          </property>
        </configuration>
        <packages>
          <package id="58a804c6-f243-4d5f-9ec0-dd4ed3e9b21b" name="go-agent">
            <configuration>
              <property>
                <key>PACKAGE_SPEC</key>
                <value>go-agent</value>
              </property>
            </configuration>
          </package>
        </packages>
      </repository>
    </repositories>

[maheshp]

Verified on GoCD Version: 20.4.0 (11733-33ea7d24052d505afd2fefdcfc2e6f6e5fd3f86f)