Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run CI tests with -race #153

Merged
merged 19 commits into from
May 3, 2018
Merged

run CI tests with -race #153

merged 19 commits into from
May 3, 2018

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented May 1, 2018 •
edited
Loading

This is a WIP branch to run tests with the -race detector.

Failing Tests:

  • TestBindings
  • TestHasherCorrectness
  • TestMessageSignVerify
  • TestSimulation
  • TestRandomBrokenData
  • TestRandomData
  • TestDataAppend
  • TestSaveSyncDb
  • TestFUSE
  • TestClientNotificationStorm
  • TestHTTPSnapshot
  • TestFailedSyncProgress64Light
  • TestMissingHeaderAttack63Fast
  • TestSyncProgress63Fast
  • TestFakedSyncProgress63Fast
  • TestHeavyForkedSync64Fast
  • TestThrottling63Full
  • TestBoundedHeavyForkedSync62
  • TestBoundedForkedSync64Fast
  • TestFastSyncDisabling
  • TestTransactionChainFork
  • TestTransactionReplacement
  • TestTransactionPoolRepricing
  • TestTransactionJournalingNoLocals
  • TestTransactionJournaling
  • TestTransactionPoolRepricingKeepsLocals
  • TestTransactionQueueGlobalLimitingNoLocals
  • TestTransactionPendingGlobalLimiting
  • TestTransactionDoubleNonce
  • TestTransactionDropping
  • TestCLISwarmUp
  • TestCmdLineOverridesFile
  • TestEnvVars
  • TestFileOverrides
  • TestCmdLineOverrides
  • TestCustomGenesis

@jmank88 jmank88 mentioned this pull request May 1, 2018
Merged
@jmank88
Copy link
Contributor Author

jmank88 commented May 2, 2018

I fixed a bunch of test races in core/tx_pool_test.go, and one real race in tx_pool.go, so that go test -race ./core passes.

@jmank88
Copy link
Contributor Author

jmank88 commented May 2, 2018

Fixed package bmt - this one seems important

@jmank88
Copy link
Contributor Author

jmank88 commented May 2, 2018

Fortunately some of these just need increased timeouts to tolerate the irregular race scheduling.

@jmank88
Copy link
Contributor Author

jmank88 commented May 3, 2018 •
edited
Loading

I've got these passing locally now. CI still has trouble with individual and overall timeouts, so we can't run this all the time yet and I removed the -race flag for now, but the fixes can be merged once they are green.

@jmank88 jmank88 changed the title WIP: run CI tests with -race run CI tests with -race May 3, 2018
@rkononov rkononov merged commit 09d913c into master May 3, 2018
@rkononov rkononov deleted the race branch May 3, 2018 12:25
This was referenced May 3, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treeder treeder Awaiting requested review from treeder

@benbjohnson benbjohnson Awaiting requested review from benbjohnson

@rkononov rkononov Awaiting requested review from rkononov

@guilhermebr guilhermebr Awaiting requested review from guilhermebr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmank88 @rkononov