Added check if image is already "dense" and fixed extension skipping #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check if image is already "dense" (in case the name already ends with “glue”+ devicePixelRatio + ‘x’), skip image with “no-dense” class and fixed extension skipping as inArray returns 0 for SVG check, that was evaluated to false and not skipped.
Modded “already dense” regex for safer detection
|
Thanks. The idea is great, but the implementation needs some work. Both security, regression, compatibility and coding style wise. I'll will absolutely merge this once it's perfected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check if image is already "dense" (in case the name already ends
with “glue”+ devicePixelRatio + ‘x’), skip image with “no-dense” class
and fixed extension skipping as inArray returns 0 for SVG check, that
was evaluated to false and not skipped.