Make sure policies are not reused between sessions #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medasx
approved these changes
Apr 11, 2022
Sharing a policy between sessions is not supported because the policy receives state updates from the session. Let's update the documentation and add a panic in TokenAwareHostPolicy constructor. It is better to panic early than to have races and undefined behavior later. See also discussion in scylladb#94
martin-sucha
force-pushed
the
ms/no-host-policy-reuse
branch
from
554432f
to
a5b0ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing a policy between sessions is not supported because the policy
receives state updates from the session.
Let's update the documentation and add a panic in TokenAwareHostPolicy
constructor. It is better to panic early than to have races and
undefined behavior later.
See also discussion in scylladb#94