Timezone is stripped from time.Time when inserting into Postgres

[kvap]

gocraft/dbr implements time serialization incorrectly, it strips the time zone away from time.Time, which results in wrong time stored in the database.

[KumanoTanaka]

https://github.com/gocraft/dbr/blob/master/dialect/mysql.go#L57

func (d mysql) EncodeTime(t time.Time) string {
    return `'` + t.UTC().Format(timeFormat) + `'`
}

↓ (I want to change this line above to below...)

func (d mysql) EncodeTime(t time.Time) string {
    return `'` + t.Format(timeFormat) + `'`
}

this may fix wrong time Create/Update problem not only in postgres but also in Mysql.

buuut.. I found the following comment
#40 (comment)

maybe we should create our own dialect(??)...

[taylorchu]

We use UTC() for backward compatibility. You can create your dialect by embedding the dialect type.

[davisdevs]

We use UTC() for backward compatibility. You can create your dialect by embedding the dialect type.

I understand using UTC() for backward compatibility.

For me, using UTC() is not an issue If the timezone is in timeFormat, as PostgresSQL would convert to the db timezone.

However, is it also for backward compatibility reasons that the timezone is stripped from timeFormat?
https://github.com/gocraft/dbr/blob/master/now.go#L11

const timeFormat = "2006-01-02 15:04:05.000000"

If so, this is a dangerous function to call and I (embarrassingly) missed the timezone stripping. A low-hanging fruit would be having a comment highlighting that it is using UTC() and timezone agnostic?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mcesar]

We use UTC() for backward compatibility. You can create your dialect by embedding the dialect type.

How? The dialect type is not exported...