Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redigo Nil Returned #153

Closed
caldempsey opened this issue Apr 8, 2020 · 0 comments
Closed

Redigo Nil Returned #153

caldempsey opened this issue Apr 8, 2020 · 0 comments

Comments

@caldempsey
Copy link
Contributor

caldempsey commented Apr 8, 2020 •
edited
Loading

Hi GoCraft maintainers

In my logs I'm seeing Redigo nil returned in cases where this returns, well nothing.

work/worker.go

Line 241 in 61759fb

logError("worker.delete_unique_job.get", err)

This is possible when there really isn't anything to get! gomodule/redigo#355

So I believe this is an edge case where we can ignore the error and return nil,nil in the response (no unique job exists/nothing to get).

How do you guys feel about this? Should I open a PR?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caldempsey