Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.18.0 conflicting with certain themes, plugins #2112

Closed
3 of 4 tasks
JoshuaGoode opened this issue Oct 21, 2021 · 2 comments · Fixed by #2113
Closed
3 of 4 tasks

2.18.0 conflicting with certain themes, plugins #2112

JoshuaGoode opened this issue Oct 21, 2021 · 2 comments · Fixed by #2113
Labels
[Priority] Low This issue/pull request is not immediate [Type] Bug Something that is not working as expected

Comments

@JoshuaGoode
Copy link

Describe the bug:

While it doesn’t appear widespread, CoBlocks 2.18.0 is conflicting with some themes.

The site might experience style and element issues as well as issues handling XML-RPC requests.

This can prevent some front-end elements of plugins from working as expected as well.

It appears that when the conflict occurs, the following gets exposed across the site and is visible in places such as WP-CLI when running commands, XMLRPC and more.

<script type="text/javascript">
document.body.className = document.body.className.replace('no-js','js');
</script>

I don't have much more than that or a clean way of reproducing and seeing the issues it causes.

Here are some known themes so far.

To reproduce:

  1. Install CoBlocks 2.18.0
  2. Install a specific theme such as Resonar
  3. With Resonar, the mobile menu with Child elements will always remain expanded.
  4. Run some commands in WP-CLI, code can sometimes leak into output

Expected behavior:

Screenshots:

Screen Shot on 2021-10-21 at 17:21:41

Isolating the problem:

  • This bug happens with no other plugins activated
  • This bug happens with a default WordPress theme active
  • This bug happens without the Gutenberg plugin active
  • I can reproduce this bug consistently using the steps above

WordPress version:

Gutenberg version:

@JoshuaGoode JoshuaGoode added [Priority] Low This issue/pull request is not immediate [Type] Bug Something that is not working as expected labels Oct 21, 2021
@JoshuaGoode
Copy link
Author

Most reports I've worked with are on WordPress.com but I can confirm the issue occurs on any host and in my local environments.

Looks like there's a report on the CoBlocks forums at https://wordpress.org/support/topic/site-logo-and-header-menu-not-showing-in-desktop-mobile/ as well.

@JoshuaGoode
Copy link
Author

Related: 3f62717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low This issue/pull request is not immediate [Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant