Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISBAT Remove "replace image" button #2257

Closed
simison opened this issue Jan 28, 2022 · 0 comments · Fixed by #2262
Closed

ISBAT Remove "replace image" button #2257

simison opened this issue Jan 28, 2022 · 0 comments · Fixed by #2262
Labels
[Priority] Low This issue/pull request is not immediate [Type] Enhancement Something new that adds functionality

Comments

@simison
Copy link

simison commented Jan 28, 2022

Is your feature request related to a problem? Please describe.

In Feb 2020 "replace image" button was added in image block sidebar (#1385).

Meanwhile, core already has — and had already in 2020 — a "replace" button in the block toolbar. Coblocks addition feels redundant:

Since button is added to the core panel via a plugin, it also interferes with core designs and makes the panel look more noisy/unbalanced:

Screenshot 2022-01-29 at 00 21 41

I had a case where button looks broken visually, but I'm yet to track why this happens:

image

Describe the solution you'd like

Could we simply remove this button and rely on a core solution instead? What value does this extra button bring?

Describe alternatives you've considered

Additional context/screenshots

@simison simison added [Priority] Low This issue/pull request is not immediate [Type] Enhancement Something new that adds functionality labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low This issue/pull request is not immediate [Type] Enhancement Something new that adds functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant