Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISNBAT edit the HTML of the Form field blocks #619

Closed
4 tasks done
richtabor opened this issue Jun 28, 2019 · 1 comment
Closed
4 tasks done

ISNBAT edit the HTML of the Form field blocks #619

richtabor opened this issue Jun 28, 2019 · 1 comment
Assignees
@AnthonyLedesma
Labels
Good First Issue A great place to start if you're new to contributing [Type] Bug Something that is not working as expected

Comments

@richtabor
Copy link
Contributor

Describe the bug
It's currently possible to edit the HTML of the child blocks within the Form block. This functionality does not work as the block is a derivative of InnerBlocks, and will cause the block to break if edited.

To Reproduce
Steps to reproduce the behavior:

  1. Add a Form block
  2. Select a field child block
  3. Click on the vertical ... to open the panel
  4. See "Edit as HTML" listed

Screenshots
Screen Shot 2019-06-28 at 12 13 57 PM

Expected behavior
The option edit the HTML of a Form field block is not present, using the following:

supports: {
	html: false,
},

Isolating the problem:
Mark completed items with an [x].

  • This bug happens with no other plugins activated
  • This bug happens with a default WordPress theme active
  • This bug happens without the Gutenberg plugin active
  • I can reproduce this bug consistently using the steps above

WordPress Environment
@richtabor richtabor added [Type] Bug Something that is not working as expected Good First Issue A great place to start if you're new to contributing [Block] Form labels Jun 28, 2019
@AnthonyLedesma AnthonyLedesma mentioned this issue Jul 2, 2019
Merged
@AnthonyLedesma
Copy link
Member

#631 closes this issue.

richtabor pushed a commit that referenced this issue Jul 3, 2019
@AnthonyLedesma @richtabor
Disable reusable and editable HTML support for Form > Field blocks (#631
0cfdcf3 
)

* Reusable and Editible Supports Opt Out

Handles #618 & #619
Added options to `supports` object to disable `html` and `reusable` properties.

* added reusable and html to FieldDefaults.supports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnthonyLedesma AnthonyLedesma

Labels
Good First Issue A great place to start if you're new to contributing [Type] Bug Something that is not working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richtabor @AnthonyLedesma