Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Social Profiles block stability through block validation testing #1057

Merged
merged 3 commits into from Oct 23, 2019
Merged

Improve Social Profiles block stability through block validation testing #1057

merged 3 commits into from Oct 23, 2019

Conversation

jrtashjian
Copy link
Member

This block did not have deprecations. Instead I added a basic test on the save function to detect when we need to write a deprecation. Related to #876.

Test Suites: 1 passed, 1 total
Tests:       9 passed, 9 total
Snapshots:   0 total
Time:        3.34s

@jrtashjian jrtashjian added [Testing] Jest [Type] Code Quality Relevant to improving the quality of our code labels Oct 22, 2019
@jrtashjian jrtashjian added this to the Next Release milestone Oct 22, 2019
@jrtashjian jrtashjian self-assigned this Oct 22, 2019
@jrtashjian jrtashjian mentioned this pull request Oct 22, 2019
Closed
3 tasks
@jrtashjian jrtashjian marked this pull request as ready for review October 22, 2019 20:19
AnthonyLedesma
AnthonyLedesma approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Approved.

@jrtashjian jrtashjian merged commit eef1d9f into master Oct 23, 2019
@jrtashjian jrtashjian deleted the issue-876-deprecation-tests branch October 23, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyLedesma AnthonyLedesma AnthonyLedesma approved these changes

@EvanHerman EvanHerman Awaiting requested review from EvanHerman

@richtabor richtabor Awaiting requested review from richtabor

Assignees

@jrtashjian jrtashjian

Labels
[Type] Code Quality Relevant to improving the quality of our code
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrtashjian @AnthonyLedesma