Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for multiple field types with same label #1146

Merged
merged 4 commits into from Nov 21, 2019
Merged

Allow for multiple field types with same label #1146

merged 4 commits into from Nov 21, 2019

Conversation

EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Nov 20, 2019 •
edited

Closes #1145

This PR allows for fields to have multiple of the same field type with the same label. Previously, data was overwritten in the global $_POST when two or more of the same field types were used with identical field labels.

image

Additional Fixes:

  • Allow for multiple date fields to be used on a page and the proper date the be input to the correct text input field. (Updated the date field IDs)
  • Added autocomplete="off" on the date field to prevent autocomplete dropdown from covering the calendar
Submitted Data Before Patch

image

Submitted Data with Patch

image

@EvanHerman EvanHerman self-assigned this Nov 20, 2019
@EvanHerman EvanHerman added this to the Next Release milestone Nov 20, 2019
@richtabor richtabor added the [Type] Bug Something that is not working as expected label Nov 21, 2019
richtabor
richtabor approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@richtabor
Copy link
Contributor

@EvanHerman, looks like tests are failing here.

@richtabor richtabor merged commit 119362e into master Nov 21, 2019
@richtabor richtabor deleted the fix/multiple-field-type-data branch November 21, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtabor richtabor richtabor approved these changes

@AnthonyLedesma AnthonyLedesma Awaiting requested review from AnthonyLedesma

@jrtashjian jrtashjian Awaiting requested review from jrtashjian

Assignees

@EvanHerman EvanHerman

Labels
[Type] Bug Something that is not working as expected
Projects
None yet
Milestone
1.17.3
Development

Successfully merging this pull request may close these issues.

ISBAT select a date from a calendar and have it input to the appropriate input
2 participants
@EvanHerman @richtabor