New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add waves masks on images feature #877
Conversation
@paranoia1906 great work! I'm about to push a few updates that build upon what you've accomplished. We can actually use the As for IE11 support, The major difference is the SVG we're using as the mask. When an SVG is used as a mask, the path added is actually the part of the image that is removed. So in order to get this working properly I made an SVG which is the reverse of the shape. So in your example above the white portion is the SVG shape whereas the new shape would be the red portion. |
I think it's fine that captions display in the preview (as core allows it). I also removed some extraneous styling that was causing some display errors in the sidebar and aren't really needed. |
The wave style is broken. See http://xizunite.com/test-image/
|
I was not able to figure out how to get the IE11 support working here. I was able to get a background image applied but the layering was not working as expected.
There are two bugs that I am still working on tracking down. They are both related to the image-mask not being 'contained'
When first inserted
When switching page alignment