Skip to content

Commit

Permalink
fix(aliasing): don't alias apis (to api) (#393)
Browse files Browse the repository at this point in the history
/api is an endpoint, so we shouldn't alias /apis to /api.

Fixes #391
  • Loading branch information
silasbw committed Jan 4, 2019
1 parent 51d83f1 commit 515a6e3
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion lib/alias.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ const esPlurals = {
ingresses: true
}

const excludeFromAliasing = {
apis: true
}

module.exports = function (resourceType) {
let aliases = [resourceType]
if (resourceAliases[resourceType]) {
Expand All @@ -55,7 +59,9 @@ module.exports = function (resourceType) {
// NOTE(sbw): try to catch things that shouldn't have singular aliases. This
// fails on some relatively common resources, like "status".
//
if (resourceType.slice(-1) !== 's') return aliases
if ((resourceType.slice(-1) !== 's') || (resourceType in excludeFromAliasing)) {
return aliases
}

const trimLength = esPlurals[resourceType] ? 2 : 1
const single = resourceType.substr(0, resourceType.length - trimLength)
Expand Down

0 comments on commit 515a6e3

Please sign in to comment.