fix(auth): remove authentication from /openapi/v2 call (#372)

godaddy · Dec 24, 2018 · ef1467a · ef1467a
1 parent 0aa7f80
commit ef1467a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/lib/request.js b/lib/request.js
@@ -175,6 +175,10 @@ class Request {
       headers: options.headers
     }, this.requestOptions)
 
+    if (options.noAuth) {
+      delete requestOptions.auth
+    }
+
     if (options.stream) return request(requestOptions)
 
     return new Promise((resolve, reject) => {

diff --git a/lib/swagger-client.js b/lib/swagger-client.js
@@ -33,14 +33,10 @@ const Request = require('./request')
 
 class Root extends Component {
   _getSpec (pathname) {
-    return this.http.http({ method: 'GET', pathname })
+    return this.http.http({ method: 'GET', pathname, noAuth: true })
       .then(res => {
         return res.body
       })
-      .catch(err => {
-        if (err.statusCode === 404) return null
-        throw new Error(`Failed to get ${pathname}`)
-      })
   }
 
   /**
@@ -49,16 +45,15 @@ class Root extends Component {
    */
   loadSpec () {
     return this._getSpec('/openapi/v2')
-      .then(res => {
-        if (res) return res
+      .catch(err => {
         return this._getSpec('/swagger.json')
       })
       .then(res => {
-        if (res) {
-          this._addSpec(res)
-          return this
-        }
-        throw new Error('Failed to get /openapi/v2 and /swagger.json')
+        this._addSpec(res)
+        return this
+      })
+      .catch(err => {
+        throw new Error(`Failed to get /openapi/v2 and /swagger.json: ${err.message}`)
       })
   }