Add NamespaceList v1 core enumeration #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was achieved by adding the string 'namespaces' to groupResources in core.js. Thus Accessing NamespaceList v1 core api
can be easily done using
`core.namespaces.get(print);`.
To maintain previous functionality I renamed the default namespace (directly on the API) to `namespace`
(single instead of plural) and updated the alias ns. Thus accessing deployments on a given NAMESPACE can be done using
`ext.namespace(NAMESPACE).deployments('').get(print);`
|
@christianjoun, thanks for this and sorry it slipped through the review cracks :/. This would break existing users. Also, " |
|
Yes, it does work in 4.0.0 now. @christianjoun works with me on that. Thanks for the reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was achieved by adding the string 'namespaces' to groupResources in core.js. Thus Accessing NamespaceList v1 core api
can be easily done using
core.namespaces.get(print);.To maintain previous functionality I renamed the default namespace (directly on the API) to
namespace(single instead of plural) and updated the alias ns. Thus accessing deployments on a given NAMESPACE can be done using
ext.namespace(NAMESPACE).deployments('').get(print);