fix(namespaces): api.namespaces('foo') usage #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergelyke
approved these changes
Feb 11, 2018
|
Thanks for getting this fix out quickly @silasbw. Really appreciate it. I've tested your fix and it works great. Do you have plans to publish a new version soon? Thanks again. |
|
Hey @austinkelleher . I'm trying to get the major release out today or tomorrow. There's one other thing I want to include. I'm putting the PRs together now. I'll update #187 when we publish to npm. |
|
@austinkelleher, I just published 4.0.0 to npm. Thanks for testing this change out. |
|
Everything is working great on 4.0.0 @silasbw. Thanks again for the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187
BREAKING CHANGE: Removes default namespace feature. With a default namespace,
api.namespaces.getis potentially ambiguous: get the default namespaces orget all namespaces. Remove the default namespace to be consistent with other
code.