Delete resource bugfix #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasbw
reviewed
Jun 6, 2018
| @@ -91,6 +91,8 @@ class BaseObject extends CallableObject { | |||
| options = {}; | |||
| } else if (typeof options === 'string') { | |||
| options = { name: options }; | |||
| } else if (typeof options === 'undefined') { | |||
There was a problem hiding this comment.
How are you calling delete? Are you also leaving cb undefined? If so, won't this.api.delete fail when it invokes the cb?
There was a problem hiding this comment.
Hi! I've been using this lib since version 3 and only update version, but not a code.
Here is example of using
const api = new Api.Api(k8sConfig); //get config from file
this.api = api.group(apiVersion); //use batch/v1 for jobs
...
await this.api.ns(defaultNS).jobs(jobName).delete(); There was a problem hiding this comment.
passing empty object into delete method works well, but it isn't documented
|
Ok, sounds good. Can you remove your changes to |
This reverts commit e1c204c.
|
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to delete resource with ...delete() it causes exception "Cannot read property 'qs' of undefined".