feat(config): support multiple config files in KUBECONFIG #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up after discussion in #322. |
silasbw
suggested changes
Sep 6, 2018
|
Of course. I will deal with it ASAP. |
jcrugzz
reviewed
Sep 10, 2018
lib/config.js
Outdated
|
|
||
| return config; | ||
| } | ||
|
|
||
| function loadKubeconfig(cfgPath) { | ||
| cfgPath = cfgPath || defaultConfigPath(); | ||
| const cfgPaths = cfgPath ? [cfgPath] : defaultConfigPath(); |
There was a problem hiding this comment.
@JacopoDaeli was thinking, should we support passing an array of config paths in here as well? i.e.
let cfgPaths;
if (!cfgPath) { cfgPaths = defaultConfigPath(); }
else if(Array.isArray(cfgPath)) { cfgPaths = cfgPath; }
else { cfgPaths = [cfgPath]; }There was a problem hiding this comment.
I was thinking that too. Not sure. In any case, that doesn't hurt, but is it useful?
@silasbw what do you think?
jcrugzz
approved these changes
Sep 10, 2018
There was a problem hiding this comment.
@JacopoDaeli LGTM, an extra test for the new API possibility could be nice but I won't block it here.
silasbw
reviewed
Sep 10, 2018
silasbw
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for multiple config files in
KUBECONFIGenv variable.Official ref: https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/#create-a-second-configuration-file
Output of
console.log(yaml.dump(merge.all(configs)))(ref to configs) is:which matches the output of
kubectl config view: