feat(auth): support auth through iam-authenticator, add example, Closes #306 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasbw
reviewed
Sep 25, 2018
| // | ||
| // Create an API client for an AWS EKS cluster using IAM authentication | ||
| // Note: In order for this to work, you must set the environment | ||
| // variable AWS_PROFILE |
There was a problem hiding this comment.
AWS_PROFILE is used here: https://github.com/godaddy/kubernetes-client/pull/332/files#diff-7b7c8857ce22c1739c6ad1ea186ca9ddR22
Should this comment be in that file?
examples/eks-auth.js
Outdated
| @@ -0,0 +1,51 @@ | |||
| /* eslint no-console:0 */ | |||
| // | |||
| // Create an API client for an AWS EKS cluster | |||
There was a problem hiding this comment.
What's the difference between this example and the one below?
There was a problem hiding this comment.
Sorry, there should only be one. Versioning error.
silasbw
reviewed
Sep 26, 2018
| @@ -0,0 +1,53 @@ | |||
| /* eslint no-console:0 */ | |||
There was a problem hiding this comment.
Can you add a link to this example from the README.md?
silasbw
reviewed
Sep 26, 2018
README.md
Outdated
| @@ -155,6 +155,8 @@ const client = new Client({ config: config.fromKubeconfig() }); | |||
| log an error: [canary-controller.js](./examples/canary-controller.js) | |||
| * Create a `client` using basic-auth: | |||
| [basic-auth.js](./examples/basic-auth.js) | |||
| * Create a `client` using IAM authenticator and cmd auth: | |||
There was a problem hiding this comment.
Maybe:
Create a `client` using IAM authenticator and cmd auth (works with EKS):
I'm trying to get EKS in there :)
silasbw
approved these changes
Sep 27, 2018
cfellin1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.