Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle optional kube config user exec properties #351

Merged
merged 2 commits into from
Oct 31, 2018
Merged

handle optional kube config user exec properties #351

merged 2 commits into from
Oct 31, 2018

Conversation

grounded042
Copy link
Contributor

this fixes #350 by making sure user.exec.env and user.exec.args are defined before using them when creating a config with user.exec.

silasbw
silasbw approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@silasbw silasbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@silasbw silasbw merged commit a854fef into godaddy:master Oct 31, 2018
@grounded042 grounded042 deleted the kube-config-exec branch October 31, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silasbw silasbw silasbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kube config user exec without optional properties causes TypeError
2 participants
@grounded042 @silasbw