Remove authentication from /openapi/v2 call #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasbw
reviewed
Dec 15, 2018
lib/swagger-client.js
Outdated
| url: this.http.requestOptions.baseUrl, | ||
| ca: this.http.requestOptions.ca | ||
| }) | ||
| return noAuthHTTP.http({ method: 'GET', pathname }) |
There was a problem hiding this comment.
What if we added a noAuth option to http? One benefit of doing that is if we modify Request or add a new version and a user constructs it with some custom configuration that we wouldn't know how to replicate when we construct it here.
Thoughts?
There was a problem hiding this comment.
That sounds good to me, would it then be accessible through this.http.noAuth.http(...) or do you have a better idea? Or am I misunderstanding?
There was a problem hiding this comment.
silasbw
reviewed
Dec 17, 2018
| @@ -33,14 +33,14 @@ const Request = require('./request') | |||
|
|
|||
| class Root extends Component { | |||
| _getSpec (pathname) { | |||
| return this.http.http({ method: 'GET', pathname }) | |||
There was a problem hiding this comment.
I was imagining something like:
return this.http.http({ method: 'GET', pathname, noAuth: true })
|
A little swamped this week but will get to this over the weekend. |
|
@silasbw Addressed comments in latest PR |
silasbw
approved these changes
Dec 24, 2018
|
Thanks again. Published with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #371