Allow passing relative root when running inCluster #383
Conversation
lib/config.js
Outdated
| @@ -32,16 +32,16 @@ function defaultConfigPaths () { | |||
| function getInCluster () { | |||
| const host = process.env.KUBERNETES_SERVICE_HOST | |||
| const port = process.env.KUBERNETES_SERVICE_PORT | |||
|
|
|||
| const root = process.env.RELATIVE_ROOT || '/' | |||
There was a problem hiding this comment.
Can we pick a kubernetes-client specific name for this environment variable? How about KUBERNETES_CLIENT_SERVICEACCOUNT_ROOT?
There was a problem hiding this comment.
Sounds good, will do asap
lib/config.js
Outdated
| @@ -32,16 +32,16 @@ function defaultConfigPaths () { | |||
| function getInCluster () { | |||
| const host = process.env.KUBERNETES_SERVICE_HOST | |||
| const port = process.env.KUBERNETES_SERVICE_PORT | |||
|
|
|||
| const root = process.env.RELATIVE_ROOT || '/' | |||
There was a problem hiding this comment.
Could we also set the default to /var/run/secrets/kubernetes.io/serviceaccount/ and update caPath, tokenPath, and namespacePath to be like ${ KUBERNETES_CLIENT_SERVICEACCOUNT_ROOT }/*? I'm guessing that would implement the behavior folks have in mind when they set the KUBERNETES_CLIENT_SERVICEACCOUNT_ROOT value.
There was a problem hiding this comment.
Not sure I fully understand, can you please give an example?
There was a problem hiding this comment.
The updates you made were what I had in mind. 👍
…ROOT with default path to what K8S master injected
|
@silasbw please check this out. export KUBERNETES_CLIENT_SERVICEACCOUNT_ROOT=$TELEPRESENCE_ROOT/var/run/secrets/kubernetes.io/serviceaccount/ |
|
Published your change with |
|
Awesome, thanks |
related to #382