Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aliasing): don't alias apis (to api) #393

Merged
merged 1 commit into from
Jan 4, 2019
Merged

fix(aliasing): don't alias apis (to api) #393

merged 1 commit into from
Jan 4, 2019

Conversation

silasbw
Copy link
Contributor

@silasbw silasbw commented Jan 4, 2019

/api is an endpoint, so we shouldn't alias /apis to /api.

Fixes #391

/api is an endpoint, so we shouldn't alias /apis to /api.

Fixes #391
@silasbw silasbw merged commit 515a6e3 into master Jan 4, 2019
@silasbw silasbw deleted the fix0 branch January 4, 2019 20:04
@hlian
Copy link

hlian commented Mar 6, 2019

@silasbw This might need a slightly bigger callout in the CHANGELOG, or a deprecation notice with console.warn. I recently ran into this issue:

  • Docker for Mac has a /apis/v1 path implemented in its proprietary version of Kubernetes
  • Official Kubernetes does not
  • We upgraded to kubernetes-client 6.8. It worked hunky-dory against Docker for Mac
  • It crashed when we pushed out to AWS, where it talked to a real Kubernetes instance
  • I made a quick trip to the CHANGELOG
  • Ended up here

Our line of code was this:

this.client.apis.v1

and now it's without the 's.' It crashed with cannot access v1 of undefined blah blah blah you're a javascript developer this is your life.

Anyway, thanks for the library, it's been very good to us otherwise. :)

@silasbw
Copy link
Contributor Author

silasbw commented Mar 6, 2019

Oh no! I'm sorry about that and you're right: I should have deprecated/warned this and made this a breaking change / major version bump. Thanks for the feedback and I'll adjust my process for similar changes going forward.

For this specific issue, I can try to get something in place to prevent others from hitting the gotcha you ran into. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants