feat: expose the current namespace on the config object #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasbw
approved these changes
Apr 1, 2019
|
Rad! thanks |
|
Published with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the current namespace to the return value of the
fromKubeconfigfunction. I noticed this value is also returned in thegetInClusterfunction.In our openshift node client(nodeshift), we us the current namespace(project in openshift terms) the user is logged into. I can derive it from calling
loadKubeconfigand then parsing the current context from the loaded config, but that makes an extra call to look up the configuration.It is more of a convenience thing and i would hate to clutter the returned object, so wanted to see your thoughts
Thanks