Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CRDs): malformed watch paths for namespaced CRDs #470

Merged
merged 1 commit into from
May 19, 2019

Conversation

iffyio
Copy link
Contributor

@iffyio iffyio commented May 19, 2019

Currently, URLs for namespaced watches for CRD
objects are incorrectly formatted (the result instead
tries to do a GET on a CRD named watch), causing k8s to
return a 404.
This patch corrects this issue

Fixes #468

Currently, URLs for namespaced watches for CRD
objects are incorrectly formatted (the result instead
tries to do a GET on a CRD named `watch`), causing k8s to
return a 404.
This patch corrects this issue

Fixes godaddy#468
Copy link
Contributor

@silasbw silasbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 💯 🌶️

@silasbw silasbw merged commit 0652b14 into godaddy:master May 19, 2019
@silasbw
Copy link
Contributor

silasbw commented May 19, 2019

kubernetes-client@8.0.0 includes this fix.

@iffyio iffyio deleted the bugfix/namespaced-crd-watches branch May 19, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watching custom resources with a namespace scope
2 participants