Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick fix for 403 throws on pod-exec #543

Merged
merged 2 commits into from
Nov 3, 2019

Conversation

Antoninbln
Copy link
Contributor

Purpose

Exec request throws 403 error.
Exec failing route : api.v1.namespaces(NAMESPACE).pods(PODNAME).exec.post().

Problem identification

ws seems to only supports authorization header for token authentication which is not passed to ws instance. Please see this answer for more details.

The issue.

I hope it helps :)

@Stono
Copy link

Stono commented Oct 1, 2019

Could we get this merged if possible? It's a real blocker for me!

@silasbw silasbw merged commit 88c43d8 into godaddy:master Nov 3, 2019
@jBouyoud
Copy link

jBouyoud commented Nov 5, 2019

@silasbw, Seems to break something else.
Since the version 8.3.5, I got Failed to get /openapi/v2 and /swagger.json: Unauthorized...
Rollback to 8.3.4 fix the issue.
I investigate why.

@silasbw
Copy link
Contributor

silasbw commented Nov 7, 2019

Ah bummer, thanks for looking into it.

@Stono
Copy link

Stono commented Nov 7, 2019

Aye this is broken on 8.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants