Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially unnecessary deprecation notice with v3.0.0rc2 #301

Closed
wayneashleyberry opened this issue Dec 10, 2021 · 0 comments 路 Fixed by #304
Closed

Potentially unnecessary deprecation notice with v3.0.0rc2 #301

wayneashleyberry opened this issue Dec 10, 2021 · 0 comments 路 Fixed by #304
Labels
bug Something isn't working

Comments

@wayneashleyberry
Copy link

wayneashleyberry commented Dec 10, 2021

馃悰 Bug Report

Using the following tartufo.toml config file, I would not expect to see any deprecation notices.

[tool.tartufo]
exclude-path-patterns = [
	{ path-pattern = 'tartufo.toml', reason = '...' },
	{ path-pattern = 'package-lock.json', reason = '...' },
	{ path-pattern = 'server/package-lock.json', reason = '...' },
	{ path-pattern = 'client/package-lock.json', reason = '...' },
]

However, running the following command tartufo scan-local-repo ., produces the following output, am I potentially missing something here?

/usr/local/lib/python3.9/site-packages/tartufo/scanner.py:325: DeprecationWarning: Old format of --exclude-path-patterns option and config file setup exclude-path-patterns = ['exclusion pattern'] has been deprecated and will be removed in a future version. Make sure all the exclusions are set up using new pattern i.e. exclude-path-patterns = [{path-pattern='exclusion pattern',reason='reason for exclusion'}] in the config file
  warnings.warn(
Time: 2021-12-10T15:36:53.587169
All clear. No secrets detected.

Expected Behavior

I would not expect to see deprecation notices.

Environment

tartufo, version 3.0.0rc2
macOS 12.0.1 (21A559)
Python 3.9.9
@wayneashleyberry wayneashleyberry added the bug Something isn't working label Dec 10, 2021
@rbailey-godaddy rbailey-godaddy mentioned this issue Dec 10, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant