Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entropy exclusions ignored when using scan-remote-repo #343

Closed
mgaspar-godaddy opened this issue Mar 31, 2022 · 1 comment 路 Fixed by #344
Closed

Entropy exclusions ignored when using scan-remote-repo #343

mgaspar-godaddy opened this issue Mar 31, 2022 · 1 comment 路 Fixed by #344
Labels
bug Something isn't working

Comments

@mgaspar-godaddy
Copy link
Contributor

馃悰 Bug Report

When running tartufo with scan-remote-repo the entropy exclusions in the remote repo's tartufo.toml are not being used.

To Reproduce

  1. Take any repo with entropy exclusions defined in a tartufo.toml that is committed to the remote repo.
  2. Clone it and scan it locally with the scan-local-repo option
  3. Now scan it using the scan-remote-repo option making sure that you aren't in a directory with a local tartufo.toml
  4. You should see differences in the output, specifically that high entropy patterns that should be excluded are now showing as issues from tartufo when scanning the remote repo.

Expected Behavior

When running tartufo with the scan-remote-repo option on a remote repo that contains a tartufo.toml, all exclusions defined in the tartufo.toml in the remote repo should be respected and used.

Code Example

mgaspar-godaddy/tartufo-scan-test provides an example repo where this behavior can be seen

Environment

Python 3.9.11
Tartufo 3.1.2

@mgaspar-godaddy mgaspar-godaddy added the bug Something isn't working label Mar 31, 2022
@mgaspar-godaddy
Copy link
Contributor Author

I hope to have a PR submitted shortly that should address and fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant