Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues about fiducial point detection #15

Closed
zhaodongsun opened this issue May 19, 2024 · 3 comments
Closed

Issues about fiducial point detection #15

zhaodongsun opened this issue May 19, 2024 · 3 comments

Comments

@zhaodongsun
Copy link

Hi, thanks for this nice work. When I use pyPPG to detect fiducial points from a PPG signal, there are no fiducial points detected at the end. The figure below shows the issue. The PPG signal is 60Hz. Does the sampling rate cause the issue? How to fix it?

image

@zhaodongsun
Copy link
Author

Here is another example.
image

@godamartonaron
Copy link
Owner

To the onset detection algorithm, a given time window is necessary, therefore you can't see the other fiducial points at the end of the record.

@zhaodongsun
Copy link
Author

Thanks for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants