Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in PPG_SQI #16

Closed
zhaodongsun opened this issue May 19, 2024 · 2 comments
Closed

A bug in PPG_SQI #16

zhaodongsun opened this issue May 19, 2024 · 2 comments

Comments

@zhaodongsun
Copy link

Hi,
there is a bug in the use_template function of ppg_sqi.py file. Perhaps else should be removed.

GODA_pyPPG/pyPPG/ppg_sqi.py

Lines 174 to 177 in 60992a5

if (n / (n + invalidn)) < normal_beat_percent_threshold:
valid = 0
else:
valid = 0

@godamartonaron
Copy link
Owner

Thank you for your comment! I will check it.

@godamartonaron
Copy link
Owner

updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants