New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`adswp`: Feature generation for holiday is wrong #2

Closed

lushep opened this issue Nov 18, 2021 · 0 comments

Collaborator

lushep commented Nov 18, 2021

Make sure is_holiday uses .dt.date() instead so it can compare all times of day.
Remove the last mean encoding.

lushep closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment