Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback when no scroll areas were found #3

Closed
jannis-baum opened this issue Nov 23, 2022 · 8 comments
Closed

Feedback when no scroll areas were found #3

jannis-baum opened this issue Nov 23, 2022 · 8 comments

Comments

@jannis-baum
Copy link

Right now, the focus changes to Scrolla and back for a split second (which makes the active app flicker) when trying to scrolla when there are no scroll areas. It might be hard to realize what's going here on for some people. Could consider adding a little popup that stays for a second or so saying there are no scroll areas.

@godbout
Copy link
Owner

godbout commented Nov 24, 2022

mostly it shouldn't happen anymore, as Sl is always going to grab at least the main window: https://github.com/godbout/Scrolla.docs/releases/tag/1.a2

BUT. there's cases where there's a window but it's not visible. so it's a little tricky. i consider this as an issue, will report and link here. not sure yet how to handle those cases then. screen flashing? popup? doing nothing?

@jannis-baum
Copy link
Author

BUT. there's cases where there's a window but it's not visible. so it's a little tricky. i consider this as an issue, will report and link here. not sure yet how to handle those cases then. screen flashing? popup? doing nothing?

Not sure if that's already included in what you meant but there's also the case where an app is activated that doesn't have any windows.

@godbout
Copy link
Owner

godbout commented Nov 24, 2022

yeah my bad, i meant exactly what you wrote.

so yeah, i'm able to handle that now. so we're back to giving a feedback when no scroll areas are found... still not really sure whether it should be the user to "understand" there's no window, or if Scrolla should explicitly make it obvious. even more now that if a (visible) window has no scroll area, Scrolla will highlight the window itself.

not saying no. still looking for/digesting the argumentation :D

@godbout
Copy link
Owner

godbout commented Nov 24, 2022

what about using the HazeOver window? the window that shows up behind others in kV? or actually on top of others when an app is in fullscreen. i could make that window flash.

@godbout
Copy link
Owner

godbout commented Nov 25, 2022

this is what i have in mind:

ScreenFlow.mp4

@jannis-baum
Copy link
Author

I definitely think it's better than having nothing happen! This way people know that they did press the key.

I'm not sure how a big fast flash of the entire screen does in terms of Accessibility though. I'm not the right person to ask about this but these thoughts come to my mind:

  • Might be too flashy for some people?
  • Looks a bit like a screenshot. Or the opposite of one🙈
  • Doesn't necessarily remind me of Scrolla because it doesn't use this HazeOver in other places does it?

So with those in mind, maybe flashing the selection border on the whole screen instead of the HazeOver could be another option? On top of that, I feel like if Apple made this, they would also play this super annoying sound that they play whenever something doesn't work😂 I can't really find anywhere my computer does it right now (maybe (hopefully) there is a way to disable it and that's what I have) but I hope you know which one I mean😁

Like I said, I am definitely not well-versed with designing for Accessibility so these are just some random thoughts!

@godbout
Copy link
Owner

godbout commented Nov 25, 2022

  • Might be too flashy for some people?

it's fabulous!

  • Looks a bit like a screenshot. Or the opposite of one🙈

indeed. it takes a shot of your face and sends it to me by email 🙈️

  • Doesn't necessarily remind me of Scrolla because it doesn't use this HazeOver in other places does it?

there's gonna be a new option for background/HazeOver window. but yes, i see your point. maybe the border thing may be better.

So with those in mind, maybe flashing the selection border on the whole screen instead of the HazeOver could be another option? On top of that, I feel like if Apple made this, they would also play this super annoying sound that they play whenever something doesn't work😂 I can't really find anywhere my computer does it right now (maybe (hopefully) there is a way to disable it and that's what I have) but I hope you know which one I mean😁

i know what you mean but i'm gonna avoid this. imagine you're listening to music (i do all the time) and you get this annoying "boing"? huh huh. let's see about the Accessibility issue later. maybe Scrolla will actually not be as useful as Wooshy on this area.

what i can say is that the flash happens exactly when you trigger the hotkey, so it's pretty clear you're/Scrolla is responsible for that. i'll shit a3 with this first and see how it feels over time. i'm afraid drawing the border, even faster, may actually be more confusing, coz you do have the borders over the whole screen sometimes, when Scrolla is dealing with Finder/the Desktop.

@godbout
Copy link
Owner

godbout commented Nov 25, 2022

done in a3: https://github.com/godbout/Scrolla.docs/releases/tag/1.a3

see how it feels with usage.

@godbout godbout closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants