Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks Are Left On Output #2

Closed
opticyclic opened this issue Dec 1, 2014 · 1 comment
Closed

Marks Are Left On Output #2

opticyclic opened this issue Dec 1, 2014 · 1 comment

Comments

@opticyclic
Copy link

After running python colorizer.py boy_md.png boy_md.png output.png --view you can see the output.
The marks are still left on the output file.

boy_bw
boy_md
output

@godfatherofpolka
Copy link
Owner

@opticyclic Thanks for the report. The reason for this error seems to be that you used a soft brush to draw the colors on the grey image, thus the color markings were "fading out" on the edge (zoom in closely on the markings and you can see this). Thus, the colorization solver finds a solution where the colors also fade out at the edge of the markings, leaving them visible and making the rest of the colours looked washed out, as this is the constraint given by the markings at their edge. (Interesting side note: The internal parts of a brush stroke are basically ignored, it's only the edges that count, thus, using a 1 px-diameter brush would be enough to mark the grey image, anything wider is just for human convenience.)

I've tried to recreate your markings using a hard/non-fuzzy brush (I'm sorry for the quality, this was done quite quickly), the input image and resulting output are attached. Can you confirm that these files work for you?
testmarked2
output

I will add a note to the readme specifying how the marking of the images should be done, roughly it's: non-fuzzy, non-transparatent, non-fading, hard edge brushes. (Better yet, I should implement a simple drawing tool directly, so this issue completely disappears).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants