Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Significant digits with both exponent and scientific calculators. ... #28

Closed

Conversation

vikramahuja1001
Copy link

...Fixes #4814.

The concept of Significant digits was broken in calculate. There were also trailing zeros in the calculate result. Eg: ''' 11X100 ''' used to return '''1100.00''', '''1+1''' -> ''' 2.00000''', '''sin(180)''' -> ''' 10^-16''' .
Exponent Calculator returns the result in form of aX10**b and scientific calculator returns normal result. Changed the number of significant digits from 6/9/12/15 to 3/6/9. Fixed the errors by changing format_decimal function in mathlib.py. Both Exponent and scientific calculators now respect the number selected in the number of significant digits in the toolbar.

@godiard
Copy link

godiard commented May 29, 2015

@vikramahuja1001, this is a different version of the patch already merged? Can we close?

@vikramahuja1001
Copy link
Author

@godiard The patched merged initially was not complete. This is the latest one. I think it should be tested for all the cases provided in the discription.

@quozl
Copy link

quozl commented May 29, 2017

Please rebase and resubmit, thanks.

@quozl quozl closed this May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants