Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using DISABLE_MODE_REMOVE with PhysicalBone3D causes a crash #333

Closed
mihe opened this issue May 16, 2023 · 0 comments · Fixed by #418
Closed

Using DISABLE_MODE_REMOVE with PhysicalBone3D causes a crash #333

mihe opened this issue May 16, 2023 · 0 comments · Fixed by #418
Labels
bug Something that isn't working as intended severity:minor Small impact on functionality or usability topic:runtime Concerning runtime behavior (or its source code)

Comments

@mihe
Copy link
Contributor

mihe commented May 16, 2023 •
edited

Originated from #160.

When using DISABLE_MODE_REMOVE and disabling a PhysicalBone3D through PROCESS_MODE_DISABLED the application crashes in WorkerThreadPool while it's processing the tasks scheduled by JoltJobSystem.

Godot Physics also seems to crash when doing this, but seems to do so in GodotBody3D::sleep_test because its space is nullptr. I'm not sure if the two are related somehow.

I've only verified this using the ragdoll in GDQuest's godot-4.0-new-features demos, specifically the 3d_physics_nodes.tscn scene, so it's not impossible that there's something specific to that setup that causes this.
@mihe mihe added bug Something that isn't working as intended topic:runtime Concerning runtime behavior (or its source code) labels May 16, 2023
@mihe mihe added the severity:minor Small impact on functionality or usability label May 23, 2023
@mihe mihe mentioned this issue Jun 2, 2023
Merged
@mihe mihe closed this as completed in #418 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that isn't working as intended severity:minor Small impact on functionality or usability topic:runtime Concerning runtime behavior (or its source code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored joints to accommodate for space changes mihe/godot-jolt
1 participant
@mihe