You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to nominate the breaking parts of #601: Refactoring the NativeClass trait to make generic registration easier. The main roadblock here is fn class_name() -> &'static str, something rather hard to produce from a generic impl.
The class_name method is mostly used to produce error messages, which we can afford to make a bit slower. The static-ness does not seem to be useful except as an optimization.
I'm proposing that we separate the class name from the implementation types themselves, in the process also allowing users to change any class names at registration site. This is just a side-effect, but might be useful in "plugin"-style libraries, like gdnative-async, for avoiding name collisions with user types.
Static class names can still be supported through a separate trait (StaticallyNamed?), which could be used as a bound for the registration methods.
Remaining tasks:
0.10.0-rc.0
to allow for last-minute breaking patchesI'd like to invite everyone to point out features/improvements they'd like to be part of v0.10.0.
In particular,
v0.10.0
milestone, it won't be implemented in the initial release.breaking-change
label and not thev0.10.0
milestone, it won't be implemented before v0.11.Thanks to everyone for your efforts! 🙂
The text was updated successfully, but these errors were encountered: