Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10 release #842

Closed
6 tasks done
Bromeon opened this issue Jan 3, 2022 · 2 comments
Closed
6 tasks done

v0.10 release #842

Bromeon opened this issue Jan 3, 2022 · 2 comments
Labels
feature Adds functionality to the library tracker Groups a list of related issues and tracks progress

Comments

@Bromeon
Copy link
Member

Bromeon commented Jan 3, 2022

Remaining tasks:

I'd like to invite everyone to point out features/improvements they'd like to be part of v0.10.0.
In particular,

  • If an issue/PR does not have the v0.10.0 milestone, it won't be implemented in the initial release.
  • If an issue/PR has the breaking-change label and not the v0.10.0 milestone, it won't be implemented before v0.11.

Thanks to everyone for your efforts! 🙂

@Bromeon Bromeon added feature Adds functionality to the library tracker Groups a list of related issues and tracks progress labels Jan 3, 2022
@chitoyuu
Copy link
Contributor

chitoyuu commented Jan 4, 2022

I'd like to nominate the breaking parts of #601: Refactoring the NativeClass trait to make generic registration easier. The main roadblock here is fn class_name() -> &'static str, something rather hard to produce from a generic impl.

The class_name method is mostly used to produce error messages, which we can afford to make a bit slower. The static-ness does not seem to be useful except as an optimization.

I'm proposing that we separate the class name from the implementation types themselves, in the process also allowing users to change any class names at registration site. This is just a side-effect, but might be useful in "plugin"-style libraries, like gdnative-async, for avoiding name collisions with user types.

Static class names can still be supported through a separate trait (StaticallyNamed?), which could be used as a bound for the registration methods.

I can implement it this weekend if deemed useful.

@Bromeon
Copy link
Member Author

Bromeon commented Jan 4, 2022

I'd like to nominate the breaking parts of #601

Good with me, thanks a lot for volunteering! I answered directly in that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds functionality to the library tracker Groups a list of related issues and tracks progress
Projects
None yet
Development

No branches or pull requests

2 participants