Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release 0.9.0-preview.0 #500

Merged
merged 1 commit into from Jul 10, 2020
Merged

Prepare for release 0.9.0-preview.0 #500

merged 1 commit into from Jul 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 29, 2020

Issue number squatting Preparation PR for the 0.9.0 preview release!

Version 0.9 contains a lot of large interface changes that are intended to be solutions to long-standing problems in the API. A lot of good contributions have been merged in the past months, and they are ready for some real-world testing! Since the changes are rather large, we'll release a preview version to weed out any problems before actually committing to the version bump. If no problems are found, this will then proceed to become 0.9!

Draft status: we'll want to clear the other issues in the 0.9 milestone before merging this.

@ghost ghost added this to the 0.9 milestone Jun 29, 2020
@ghost ghost marked this pull request as ready for review July 2, 2020 06:30
@ghost ghost requested a review from karroffel July 2, 2020 06:31
@ghost
Copy link
Author

ghost commented Jul 2, 2020

Updated README and CHANGELOG. The 0.9 milestone is almost done so I think this is ready for review!

@ghost ghost requested a review from halzy July 2, 2020 06:31
CHANGELOG.md Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jul 3, 2020

Removed #514 from known issues. Removed the information about 4.0 support from known issues as well, since it's mentioned in README.

@ghost
Copy link
Author

ghost commented Jul 7, 2020

Rebased and updated CHANGELOG and README. I have trimmed most example section in favor of the tutorial in the book. Please tell me if this is a good direction!

@ghost ghost requested a review from karroffel July 7, 2020 04:40
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -43,10 +45,10 @@ crate-type = ["cdylib"]
The bindings are currently generated from the API description of Godot 3.2 by default. To use the bindings with another version or a custom build, one currently has to use the bindings as a local dependency:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this can be changed too as full local clone is technically not needed anymore? With a section in the book about custom bindings this should be obsolete?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a PR to add a guide to the book: godot-rust/book#7

@ghost
Copy link
Author

ghost commented Jul 9, 2020

Planning to finish the migration guide and publish the version tomorrow!

README.md Outdated
// methods MUST have `owner: BaseClass` as their second arguments,
// before all other arguments in the signature.
#[export]
#[export]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be indented as before

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@ghost
Copy link
Author

ghost commented Jul 10, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 10, 2020

Build succeeded:

@bors bors bot merged commit 43a914f into godot-rust:master Jul 10, 2020
@ghost
Copy link
Author

ghost commented Jul 10, 2020

To authors of third-party resources:

We're about to release version 0.9, which contains many breaking changes that make it incompatible with older resources for 0.8.x. If you're willing to update your tutorials / projects for 0.9 (preview release), please let us know. Third-party resources that are not updated will be removed from README at 0.9 release.

Cc: @tom-leys @hagsteel @paytonrules @tommywalkie

@hagsteel
Copy link
Contributor

I've updated my guide.

@paytonrules
Copy link
Contributor

paytonrules commented Jul 10, 2020 via email

@tommywalkie
Copy link

tommywalkie commented Jul 11, 2020

@toasteater @karroffel Thanks for the update ! Gotta look at CHANGELOG and update my guide 👍
Unrelated : Thanks for adding my boilerplate project into third-party resources section !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants