Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Clip Markdown+Math to HTML' command does not work when plugin is installed from inside VSCode #36

Closed
DERAlfons opened this issue Oct 18, 2017 · 6 comments

Comments

@DERAlfons
Copy link

Summary

The Clip Markdown+Math to HTML command does not work for me.
It also never did work for me, but before version 2.0 there was another command, which put out the generated html to a new vscode window.

Expected behavior

When i run the command Clip Markdown+Math to HTML (or press Ctrl+K .), the generated html code for my markdown document should be copied to my clipboard and a message should appear, which tells me that that happened.

Actual behavior

When i run the command Clip Markdown+Math to HTML (or press Ctrl+K .) (after i generated the html code for my document using the Open Preview command and while having the tab with the markdown code active), nothing is copied to my clipboard (my clipboard contains the same thing it contained before running the command) and no message appears.

Environment

     Operating system: Ubuntu 16.04
       VSCode version: Version 1.17.0
                       Commit be377c0faf7574a59f84940f593a6849f12e4de7
                       Date 2017-10-04T23:33:45.303Z
                       Shell 1.7.7
                       Renderer 58.0.3029.110
                       Node 7.9.0
                       Architecture x64
Markdown+Math version: 2.0.7
@DERAlfons
Copy link
Author

I looked into the issue some more and found out, that the command works when i install the plugin from the command line, but reproduceably does not work when i install the plugin from inside of VSCode.

What could be causing this?

@DERAlfons DERAlfons changed the title 'Clip Markdown+Math to HTML' command does not work 'Clip Markdown+Math to HTML' command does not work when plugin is installed from inside VSCode Oct 19, 2017
@goessner
Copy link
Owner

Hello,

I cannot verify this effect with windows 10. But your last observation is really interesting. Nevertheless I have no clue, looking at the javascript code, which code fraction should be responsible here.

So -- help requested -- can someone else confirm this bug with ubuntu OS ?

Please test with both installation cases the existence of all node_modules:

grafik

thanks ...

@DERAlfons
Copy link
Author

I looked for the node_modules and here is what I found:

When installing from within VSCode, all required node_modules are there.

When installing from the command line with npm install, all required node_modules are there, and a lot more, 258 in total:
pastebin

Here is also the output of npm install:
pastebin

It seems like the additional module vscode and its dependencies are being installed.

@goessner
Copy link
Owner

goessner commented Oct 22, 2017

obviously there is missing something ...
.. can you do me a favor and modify your mdmath/extension.js file according to ..
grafik
.. and observe, what happens .. ?

thanks

@LCAR979
Copy link

LCAR979 commented Mar 17, 2018

@goessner #44 poster here, and let me know if I can help. I see you code pasted is just same with my local version(mdmath 2.1.0)

@goessner
Copy link
Owner

goessner commented Mar 19, 2018

It works now ...

sindresorhus/clipboardy#36 (comment)

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants