Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm upgrade process #139

Closed
alexciesielski opened this issue Jan 28, 2024 · 1 comment
Closed

Helm upgrade process #139

alexciesielski opened this issue Jan 28, 2024 · 1 comment

Comments

@alexciesielski
Copy link
Contributor

Hey, first of all - amazing work. I definitely plan on becoming a contributor (sidenote: I would love to see a list of issues that would suggest what I could start contributing to).

I just used the nx plugin to scaffold the code for the input and button to get a feel for the library, and immediately I started wondering how I should use/extend the button for example.

Let's assume I want to add a [loading] input to all my buttons. If I add it directly to the generated helm button, I assume I will run into problems in future versions if I rerun the generator?

Or will there be nx migration scripts?

Or in other words, can you elaborate how the upgrade process will look like?

@alexciesielski
Copy link
Contributor Author

I played around with it a bit and also read up on shadcn and figured it out. It seems the idea behind shadcn (and therefore behind spartan) is to have full control over your component library, meaning you own your code, but that also comes with the downside of having to manually change it whenever updates to shadcn/spartan appear.

I'll get to coding then :) let me know if there's anything I can contribute and maybe also where to find a list of tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant