Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research Object Crate #119

Closed
github-actions bot opened this issue Nov 22, 2023 · 8 comments
Closed

Research Object Crate #119

github-actions bot opened this issue Nov 22, 2023 · 8 comments

Comments

@github-actions
Copy link

github-actions bot commented Nov 22, 2023

http://purl.org/np/RAcYMfIt1ICpNTg0RCiR0QHfNoSUU-b-5Yw3w06HSL9VA

Review

Item Detail
Person name Iseult Lynch
ORCID 0000-0003-4250-4584
FSR long name Research Object Crate
FSR thing http://purl.org/np/RAoL8yweXQtkI0nrPZEFwx2ft8DebueFFjWd7rjZr9qOM#RO-Crate
FSR np identifier http://purl.org/np/RAcYMfIt1ICpNTg0RCiR0QHfNoSUU-b-5Yw3w06HSL9VA
URI of duplicate(s) (multiple separated by ';') http://purl.org/np/RAoL8yweXQtkI0nrPZEFwx2ft8DebueFFjWd7rjZr9qOM
Links correct Y
Proposed Links
Definition ok Y
FSR types ok Y
FAIRSharing DOI to be added https://doi.org/10.25504/FAIRsharing.wUoZKE
FSR creator in pubinfo (yellow): FIP Wizard (F) or the ORCID 0000-0002-7567-0311
proposal: accept (A) / Improve (I) / Retract (R) / Disapprove (D) I
Proposed changes: Add RO-Crate to long name, Add that it is a "provenance model" and a "metadata-data linking schema". Disapprove duplicate which has only metadata schema listed, Add FAIRsharing DOI

Revisions

Item Action
actual changes: accept (A) / Improve (I) / Retract (R) / Disapprove (D),URI of updated FSR D
if FSR is useless, check affected FIPs or SIPs (title)
Updated (U) /Deleted (D) entry in FIP/SIP
@IseultLynch
Copy link
Contributor

Ready to review please.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2024
@IseultLynch IseultLynch reopened this Mar 17, 2024
@TassosP78
Copy link
Contributor

Approve

@TassosP78 TassosP78 assigned IseultLynch and unassigned IseultLynch Mar 21, 2024
@mabablue
Copy link
Contributor

mabablue commented Apr 20, 2024

Hi both, I disagree! It should also include provenance model, see https://www.researchobject.org/ro-crate/1.2-DRAFT/context.jsonld and see also the RO-Crate project (https://fip-wizard.ds-wizard.org/wizard/projects/c8e39b76-8964-4222-b41b-d3bc83f8193b) from Stian Soiland-Reyes, who is a co-developer of RO-Crate. I also would advice to add "metadata-data linking schema" which RO-Crate certainly is. Also the acronym RO-Crate needs to be added in the long name and it should be mapped to FAIRSharing record: https://doi.org/10.25504/FAIRsharing.wUoZKE.

@burgerga
Copy link
Contributor

burgerga commented Apr 26, 2024

@mabablue agree to both! The RO-crate structure documentation shows (in a more human-readable way ;) ) how metadata-data should be linked, and how provenance data could be included.

@IseultLynch
Copy link
Contributor

Thanks @burgerga and @mabablue. Have added the needed improvements and once approved I will go ahead and update the respective nanopublications.

@mabablue
Copy link
Contributor

@mabablue
Copy link
Contributor

mabablue commented May 3, 2024

I have disapproved both nanopublication descriptions, created a new one based on this description and improved the FIP that used the duplicate.

@mabablue mabablue closed this as completed May 3, 2024
@mabablue
Copy link
Contributor

mabablue commented May 3, 2024

All finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants