Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Adaptor does not implement the hijacker on ResponseWriter #75

Open
R00T99 opened this issue Aug 3, 2021 · 5 comments
Open

Adaptor does not implement the hijacker on ResponseWriter #75

R00T99 opened this issue Aug 3, 2021 · 5 comments

Comments

@R00T99
Copy link

R00T99 commented Aug 3, 2021

ResponseWriter does not implement http.Hijacker

More info: github.com/gorilla/websocket/issues/640

@kantum
Copy link

kantum commented Mar 3, 2022

I would love this feature as well, I'm porting a codebase to fiber and do not want to reimplement all the websocket part for the moment.

@arsmn
Copy link
Contributor

arsmn commented Apr 29, 2022

netHTTPResponseWriter is very simple and does not implement http.Hijacker.
I think it's better to open an issue in fasthttp.
It's highly recommended to avoid using adaptor.

@timo-klarshift
Copy link

@arsmn why is it recommended to avoid adaptor? And by whom?

@ReneWerner87
Copy link
Member

Because of performance, by converting to the standard net http request or response, the allocations that fasthttp avoids are used.

@leonklingele
Copy link
Member

This should be opened here: https://github.com/valyala/fasthttp/issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants