Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃Ч [Maintenance]: Update golangci-lint #2816

Closed
3 tasks done
nickajacks1 opened this issue Jan 27, 2024 · 1 comment 路 Fixed by #2817
Closed
3 tasks done

馃Ч [Maintenance]: Update golangci-lint #2816

nickajacks1 opened this issue Jan 27, 2024 · 1 comment 路 Fixed by #2817

Comments

@nickajacks1
Copy link
Member

Maintenance Task Description

As of writing, the latest version of golangci-lint is v1.55.2. This issue encompasses updating the github actions to use at least this version of golangci-lint along with updating the .golanci.yml config to enable or disable new rules and linters as agreed upon by the fiber team.

In addition to the new linters, there are several new linter rules for existing linters, many of which raise errors in the current codebase. These will likely need to be inspected individually.

Impact on the Project

Updating the linter benefits the project by keeping up with modern Go practices, maintaining code consistency, and reducing the probability of bugs and API issues.

Additional Context (optional)

No response

Checklist:

  • I have confirmed that this maintenance task is currently not being addressed.
  • I understand that this task will be evaluated by the maintainers and prioritized accordingly.
  • I am available to provide further information if needed.
@efectn
Copy link
Member

efectn commented Jan 27, 2024

We should add support for fieldalignment linter too.

@efectn efectn added this to the v3 milestone Jan 27, 2024
@ReneWerner87 ReneWerner87 linked a pull request Jan 28, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants