Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰[Bug]: internal/storage/memory/memory_test #2872

Closed
sixcolors opened this issue Feb 21, 2024 · 2 comments
Closed

馃悰[Bug]: internal/storage/memory/memory_test #2872

sixcolors opened this issue Feb 21, 2024 · 2 comments

Comments

@sixcolors
Copy link
Member

sixcolors commented Feb 21, 2024

A problem was just noticed in internal/storage/memory/memory_test.go where var testStore = new is set globally in the package, and I got memory corruption issues, that randomly occurred. Since this pkg is using sync and a mutex, we should probably investigate the cause.

--- FAIL: Test_Storage_Memory_Delete (0.00s)
    memory_test.go:98: 
                Error Trace:    /Users/sixcolors/Documents/GitHub/fiber/internal/storage/memory/memory_test.go:98
                Error:          Should be empty, but was [100 111 101]
                Test:           Test_Storage_Memory_Delete
FAIL

Originally posted by @sixcolors in #2871 (comment)

@gaby
Copy link
Member

gaby commented Mar 6, 2024

@sixcolors This is fixed by #2892

@gaby
Copy link
Member

gaby commented Mar 17, 2024

Fixed via #2892

@gaby gaby closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants